Retry clops #3800
Merged
Retry clops #3800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-3800.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cop8vn7109ks73fabtog. |
|
haileyok
reviewed
May 1, 2024
Comment on lines
+76
to
+86
| export function isConvoItemMessage( | ||
| item: ConvoItem, | ||
| ): item is ConvoItem & {type: 'message'} { | ||
| if (!item) return false | ||
| return ( | ||
| item.type === 'message' || | ||
| item.type === 'deleted-message' || | ||
| item.type === 'pending-message' | ||
| ) | ||
| } | ||
|
|
There was a problem hiding this comment.
I think we want ConvoItem to always include sender so that we can use a single MessageItem for rendering these. Then we can handle different logic based on the type.
haileyok
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.