Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow unmuting and unblocking of curate lists, but not the opposite #3817

Merged
merged 1 commit into from
May 2, 2024

Conversation

estrattonbailey
Copy link
Member

@estrattonbailey estrattonbailey commented May 2, 2024

We were still allowing users to mute/block user lists. We made this mistake a long time ago, and at the time, backend actually allowed user lists to block and mute other users. We've since updated this so that only moderation lists work in this way, but some users still have user lists that are blocked or muted.

The intention is to NOT allow users to block/mute user lists. But if they have them blocked/muted bc of this mistake, we should allow them to un-do this. That's what this PR does.

Copy link

render bot commented May 2, 2024

Copy link

github-actions bot commented May 2, 2024

Old size New size Diff
6.85 MB 6.85 MB -92 B (-0.00%)

Copy link
Collaborator

@pfrazee pfrazee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didnt test but at a glance the logic looks right

@estrattonbailey
Copy link
Member Author

Tested both scenarios, should be good

@estrattonbailey estrattonbailey merged commit c206275 into main May 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants