[Clipclops] Moar error #3837
Merged
[Clipclops] Moar error #3837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-3837.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-coq56lq1hbls73fl8mu0. |
|
estrattonbailey
commented
May 3, 2024
| if (this.pastMessages.size > 0) { | ||
| await new Promise(y => setTimeout(y, 500)) | ||
| } | ||
| if (this.headerItems.has(ConvoError.HistoryFailed)) return |
There was a problem hiding this comment.
There should only ever be one of these since I'm using the ConvoError as the key, so I'm thinking this should be safe. Alternatively we could add other booleans to the class.
haileyok
approved these changes
May 3, 2024
estrattonbailey
added a commit
that referenced
this pull request
May 3, 2024
* origin/main: make service url gate friendlier (#3841) remove broken keyboard offset code (#3842) [Clipclops] Header tweaks (#3839) update date logic to account for timezones (#3840) [Clipclops] Moar error (#3837) [Session] Reset global agent on expire (#3838) [Session] Rely on agent session change event for persisting resumed session (#3836)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review without whitespace: https://github.com/bluesky-social/social-app/pull/3837/files?diff=split&w=1
This PR introduces some new
ConvoTypes,error-fatal(unused atm) anderror-recoverable, which has aretrymethod and will probably be used differently from the fatal version (if we even need that). The idea is to insert a givenConvoErrortype into the flow of items.This PR handles only failed history fetches. But imagine similar errors appearing above or below other messages.