[Clipclops] Delete message in dialog #3849
Conversation
|
Your Render PR Server URL is https://social-app-pr-3849.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-coqjtj2cn0vc73fmfua0. |
|
src/components/dms/MessageMenu.tsx
Outdated
| }, []) | ||
| if (chat.status !== ConvoStatus.Ready) return | ||
|
|
||
| chat.deleteMessage(message.id) |
There was a problem hiding this comment.
This can throw FYI. It optimistically removes the message immediately, but if it fails, it's re-inserted immediately too. My thinking is that we want to handle in situ and alert the user so they can retry right from the dialog.
There was a problem hiding this comment.
so delete message first and then close the dialog?
There was a problem hiding this comment.
Yeah could just wait for it to delete, show error if fails, then close
There was a problem hiding this comment.
Could consider other options for sure, but if someone wants to delete a message, we should make sure they know when it fails
There was a problem hiding this comment.
cool, sg. will think about it today.
mozzius
force-pushed
the
hailey/delete-copy
branch
from
234f0ed to
106e4eb
Compare
mozzius
changed the title
|
Rebased, I did the copy message text in a different PR |
|
Added a retry dialog |
No description provided.