[Session] Code cleanup #3854
Merged
[Session] Code cleanup #3854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-3854.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-coqog3uv3ddc73dofu1g. |
|
gaearon
force-pushed
the
session-cleanup
branch
3 times, most recently
from
9ec2994 to
ef21c07
Compare
Merged
estrattonbailey
approved these changes
May 6, 2024
| agent.session = prevSession | ||
| if (!storedAccount.deactivated) { | ||
| // Intentionally not awaited to unblock the UI: | ||
| networkRetry(1, () => agent.resumeSession(prevSession)) |
gaearon
force-pushed
the
session-cleanup
branch
4 times, most recently
from
0dfd8c2 to
1b17af9
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup after #3852.
Moving things around files to better split responsibilities.
Shifts some async work to be more parallel.
Also solves race conditions between
SessionApicalls by adding anAbortController.The best way to review this is probably just to browse the final directory.