-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[🐴] State transitions #3880
Merged
Merged
[🐴] State transitions #3880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your Render PR Server URL is https://social-app-pr-3880.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cosluafsc6pc739kue60. |
|
(cherry picked from commit 8385579d31500bb4bfb60afeecdc1eb3ddd7e747)
(cherry picked from commit 7f75cd04c3bf81c94662785748698640a84bef51)
(cherry picked from commit b82b552ba4040adf7ead2377541132a386964ff8)
gaearon
approved these changes
May 7, 2024
estrattonbailey
added a commit
that referenced
this pull request
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewing without whitespace helps a bit.
This PR handles state transitions from app foreground to background, including tab focus on web. It also begins to guard async data fetching from being called while another request is in-flight.
To do so, I refactored the state transition logic into a reducer. All updates to
this.status
go through this reducer. Various side effects are then called.status
This should make it far more clear what's happening, and help us avoid invalid states.
Testing
I recommend uncommenting the
debug
log withinpollEvents
for more visibility into what's happening.suspended
backgrounded
suspended
ready
->backgrounded
->ready
backgrounded
statethrow
cases to test error states (some UI is needed)convo.ts
should also work fine