Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[🐴] Handle errors, improve styling #3937

Merged
merged 2 commits into from
May 10, 2024
Merged

[🐴] Handle errors, improve styling #3937

merged 2 commits into from
May 10, 2024

Conversation

estrattonbailey
Copy link
Member

This PR:

  • gets rid of original retry message UI and handling and replaces with the same handling as other errors
  • makes sure all network errors are handled
  • improves styling

CleanShot 2024-05-09 at 16 36 02@2x
CleanShot 2024-05-09 at 16 36 32@2x
CleanShot 2024-05-09 at 16 38 00@2x
CleanShot 2024-05-09 at 16 38 04@2x

@render Render
Copy link

render bot commented May 9, 2024

Your Render PR Server URL is https://social-app-pr-3937.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-coukb4v109ks73e5aq7g.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024

Old size New size Diff
6.9 MB 6.9 MB -346 B (-0.00%)

mozzius
mozzius approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@mozzius mozzius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@estrattonbailey estrattonbailey merged commit 195c9f1 into main May 10, 2024
6 checks passed
@tkusano tkusano mentioned this pull request May 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mozzius mozzius mozzius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@estrattonbailey @mozzius