Let Expo/Webpack handle CSS assets #3942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mary-ext
commented
May 10, 2024
bskyweb/templates/base.html
Outdated
Comment on lines
256
to
415
| </style> | ||
| </style> |
There was a problem hiding this comment.
Never even noticed the double closing tag until now 😅
mary-ext
force-pushed
the
feat/css-assets
branch
from
16dd5d8 to
0173182
Compare
gaearon
force-pushed
the
feat/css-assets
branch
2 times, most recently
from
79f425d to
3f1501c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #3929, see #3929 (comment)
Manually sharing CSS code between
web/index.html(dev builds) andbskyweb/templates/base.html(production) is brittle, let's have it handled as a built asset instead.This also means hot-reloading on development, well, hopefully it should.
Small savings gained from minification (reduction of ~2kb uncompressed)