[🐴] Remove extra spinner states from chat screen #3947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-3947.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-coutbsi1hbls73f4u7og. |
|
haileyok
commented
May 10, 2024
| @@ -553,7 +553,7 @@ export class Convo { | |||
| { | |||
| cursor: nextCursor, | |||
| convoId: this.convoId, | |||
| limit: isNative ? 40 : 60, | |||
| limit: isNative ? 30 : 60, | |||
There was a problem hiding this comment.
This needs to be the same as initialNumToRender in messagesList. If it's larger, there will be a scroll animation on render.
I'd like to keep this below 30 if we can, especially whenever we start considering adding other content types than text (honestly we might need to decrease the number when that happens, at least on native)
Comment on lines
-59
to
-69
| if ( | ||
| convo.status === ConvoStatus.Uninitialized || | ||
| convo.status === ConvoStatus.Initializing | ||
| ) { | ||
| return ( | ||
| <CenteredView style={a.flex_1} sideBorders> | ||
| <Header /> | ||
| <ListMaybePlaceholder isLoading /> | ||
| </CenteredView> | ||
| ) | ||
| } |
There was a problem hiding this comment.
Commented on other PR already, but want to discuss this a bit. Not necessarily a blocker but want to be sure we can't do this another way.
estrattonbailey
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picking this out of #3945, because it's really separate from that PR and I'd like to get this one in to test on device.