[🐴] Simplify message passing, cleanup #3952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-3952.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cov3hhe3e1ms73chke6g. |
estrattonbailey
commented
May 10, 2024
Comment on lines
+744
to
+745
| // remove on each send, it might go through now without user having to click | ||
| this.footerItems.delete(ConvoItemError.PendingFailed) |
There was a problem hiding this comment.
Noticed while testing this that if a send fails, and you send another that succeeds, you'll have no pending messages but the retry error will still be present. In this case, which is now fixed, if you click retry, it simply removes itself and does nothing, since there are no pending messages left.
estrattonbailey
commented
May 10, 2024
| } | ||
| } | ||
| }, | ||
| {convoId: this.convoId}, |
There was a problem hiding this comment.
Without this optional param, it will receive all logs events for all chats. For the purposes of Convo we obviously only want this particular convo.
|
haileyok
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the contract between the two agents and removes some unused types. It also ensures the events are torn down when the class is suspended.