-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move request for notifications permissions to HomeReadyScreen
#3977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your Render PR Server URL is https://social-app-pr-3977.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cp05pf8l6cac73av7u8g. |
|
haileyok
commented
May 12, 2024
estrattonbailey
approved these changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Asking for permissions randomly at the start of onboarding can be pretty jarring and might result in more denials of permission. Instead, we can ask for permission after onboarding is complete.
We also want to be able to track this, so I have:
notifications:request
status
with valuesgranted
,denied
, orundetermined
- the default values for Expo NotificationsOn top of these changes, I am fixing/cleaning up some other logic. On main right now, we can see that we are registering the push token multiple times on app launch:
As noted below, that is because we are
Instead, what I have done is call
getDevicePushToken()
on DID change without registering it, then let the change listener handle the registration. This is the result:Test Plan
Different gate configurations should be tested:
Reduced Onboarding: False, Request After Onboarding: False
RocketSim_Recording_iPhone_15_Pro_6.1_2024-05-11_22.50.05.mp4
Reduced Onboarding: True, Request After Onboarding: False
RocketSim_Recording_iPhone_15_Pro_6.1_2024-05-11_22.56.02.mp4
Reduced Onboarding: True/False, Request After Onboarding: True
RocketSim_Recording_iPhone_15_Pro_6.1_2024-05-11_22.58.20.mp4