[🐴] New chat dialog refresh #4071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
estrattonbailey
commented
May 17, 2024
•
estrattonbailey
commented
- Android border radius on dialog
|
Your Render PR Server URL is https://social-app-pr-4071.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cp3arrsf7o1s73eni4ug. |
|
estrattonbailey
force-pushed
the
dms/new-chat
branch
from
892c014 to
7239313
Compare
estrattonbailey
commented
May 17, 2024
Comment on lines
+280
to
+281
| borderTopLeftRadius: 40, | ||
| borderTopRightRadius: 40, |
There was a problem hiding this comment.
Prevents overflow in the corners, needs to match Inner
estrattonbailey
commented
May 17, 2024
src/components/Dialog/index.web.tsx
Outdated
Comment on lines
204
to
205
| FlatListProps<any> & {label: string} & { webInnerStyle?: StyleProp<ViewStyle> } | ||
| >(function InnerFlatList({label, style, webInnerStyle, ...props}, ref) { |
There was a problem hiding this comment.
Need to override some styles on web bc of this composition
estrattonbailey
commented
May 17, 2024
| @@ -20,6 +20,7 @@ export const RQKEY = (prefix: string) => [RQKEY_ROOT, prefix] | |||
| export function useActorAutocompleteQuery( | |||
| prefix: string, | |||
| maintainData?: boolean, | |||
| limit?: number, | |||
There was a problem hiding this comment.
Really shouldn't use positional props but didn't want to make edits in all the other files
There was a problem hiding this comment.
yea all good, felt the same way when i added the maintainData
haileyok
reviewed
May 17, 2024
| onScrollBeginDrag={() => Keyboard.dismiss()} | ||
| /> | ||
| ) | ||
| } |
There was a problem hiding this comment.
holy shit almost 500LOC what a screen!
haileyok
approved these changes
May 17, 2024
# Conflicts: # src/screens/Messages/List/index.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.