-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[🐴] DM button on profile #4097
[🐴] DM button on profile #4097
Conversation
Your Render PR Server URL is https://social-app-pr-4097.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cp4grmicn0vc73dto35g. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great! One last thing
if (!convoId) return null | ||
|
||
return ( | ||
<Button |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make this a Link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* origin/main: Update French localization (#4113) Update Japanese translations (#3886) Update pt-BR localization to latest version (#4009) Update zh-CN translations (#3932) Update zh-TW translations (#4025) Update Korean localization (#4030) Update catalan messages.po (#4079) Update Spanish Localization (#4105) Allow removal of feeds that fail to load (#4121) [🐴] Make message input layout resizing synchronous (#4123) [🐴] Adjust content height whenever the emoji picker keyboard is opened or closed (#4120) Conditionally set chat declaration (#4122) [🐴] Fix load state for disabled chats (#4119) Bump api sdk (#4118) [🐴] Switch back to encouraging users to report messages (#4117) convo button skeleton (#4115) [🐴] Screenreader accessibility actions for individual chat items (#4116) [🐴] DM button on profile (#4097) [🐴] Don't retry sends (#4111)
Calls
getProfileForMembers
to decide whether or not to show the button, since you can still chat someone if they have DMs closed if you already have an ongoing chat (I set mozzius.dev tonone
if you want to test). Means that it pops in after the rest of the profile but it doesn't cause layout shift. Buttons now wrap if needed, rather than flowing behind the avatar. Also includes a cleanup of the button sizes to make them all equal sizes (because before they were all different apparently????)Opted not to show on labellers, you can still message them through the new chat dialog if you really need to but I think we want to avoid the perception of labellers as normal users.