Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Statsig] Fix exposure logging for reduced onboarding #4131

Merged
merged 3 commits into from
May 20, 2024

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented May 20, 2024

First commit adds an option that disables exposure logging for a specific gate check. Then we rename the onboarding experiment name (to get fresh data) and enable the option for the place where we don't want exposures.

Test Plan

Add a logpoint to Statsig exposure logger.

Screenshot 2024-05-20 at 23 30 06

Confirm that on main, we expose the user to the onboarding experiment while on Following tab.

Screenshot 2024-05-20 at 23 28 33

Confirm that on this branch, we don't.

Screenshot 2024-05-20 at 23 28 20

Copy link

render bot commented May 20, 2024

Copy link

Old size New size Diff
6.87 MB 6.87 MB 217 B (0.00%)

Copy link
Member

@estrattonbailey estrattonbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautifully done ✨

@gaearon gaearon merged commit 4fa92d7 into main May 20, 2024
6 checks passed
@gaearon gaearon deleted the statsig-exposure-logging branch May 20, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants