Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐴] Empty chat prompt #4132

Merged
merged 8 commits into from
May 20, 2024
Merged

[🐴] Empty chat prompt #4132

merged 8 commits into from
May 20, 2024

Conversation

estrattonbailey
Copy link
Member

No description provided.

Copy link

render bot commented May 20, 2024

Copy link

github-actions bot commented May 20, 2024

Old size New size Diff
6.87 MB 6.87 MB 2.84 KB (0.04%)

Comment on lines 343 to +357
<KeyboardStickyView offset={{closed: -bottomOffset, opened: 0}}>
{!blocked ? (
{convoState.status === ConvoStatus.Disabled ? (
<ChatDisabled />
) : blocked ? (
footer
) : (
<>
{convoState.status === ConvoStatus.Disabled ? (
<ChatDisabled />
) : (
<MessageInput onSendMessage={onSendMessage} />
{isConvoActive(convoState) && convoState.items.length === 0 && (
<ChatEmptyPill />
)}
<MessageInput onSendMessage={onSendMessage} />
</>
) : (
footer
)}
</KeyboardStickyView>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved everything into KeyboardStickyView so that the pill follows the keyboard up.

Comment on lines 138 to 142
const onLongPress = useCallback(() => {
playHaptic()
menuControl.open()
}, [menuControl])
}, [playHaptic, menuControl])

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated but while testing i realized there was no haptic here and it felt off

@haileyok haileyok merged commit a7b0242 into main May 20, 2024
6 checks passed
@haileyok haileyok deleted the dms/empty-chat branch May 20, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants