Make list end text customizable #4145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4145.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cp61j8ed3nmc73f4o0l0. |
pfrazee
approved these changes
May 21, 2024
|
tkusano
added a commit
to tkusano/social-app
that referenced
this pull request
May 21, 2024
pfrazee
pushed a commit
that referenced
this pull request
May 24, 2024
* Updated Japanese translation * Updated Japanese translation to resolve conflicts and updated msg * Updated Japanese translation ref. #4145 * changed the "Clip clop" translation * Updated Japanese translation * Updated Japanese translation * Updated Japanese translation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We added an end message to the list footer, thought it felt a little too generic. Instead, let's keep them disabled by default and we can add them as we want.
I added one to the conversation list screen for now, which reads "No more conversations to show". Definitely can add this elsewhere - like the end of a post thread to signify that there's no more posts, but we can do that later.
Test Plan
Check a post thread, and there should not be a footer. However, if you go to the chats tab, there should be a footer that says "No more conversations to show".