More retries when resuming non-stale account #4156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4156.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cp6dt1i0si5c73b0tseg. |
|
gaearon
approved these changes
May 21, 2024
|
I'll have a look at improving this based on the things I mentioned above, but yeah for now this won't hurt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few of us have noticed getting signed out occasionally. For me anyway, this seems to happen when resuming from a background state e.g. foregrounding the app, or opening my laptop after being away.
The thinking in this PR is: if we have checked your JWT and it's not expired, we want to be very sure the
resumeSessioncall returns a real failure, and not some sort of network issue while the device reconnects to its wifi/cellular.Other things that could be done here: