[🐴] Fix Firefox send button positioning #4201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4201.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cp7osmv109ks73etmvl0. |
|
set to `38` remove some extra stuff equal height on all platforms
haileyok
force-pushed
the
hailey/firefox-button-centering
branch
from
bf06868 to
d151ffa
Compare
| @@ -92,11 +93,12 @@ export function MessageInput({ | |||
| a.flex_row, | |||
| t.atoms.bg_contrast_25, | |||
| { | |||
| paddingHorizontal: a.p_sm.padding - 2, | |||
| paddingRight: 6, | |||
There was a problem hiding this comment.
Using the atom is just to indicate that it's suppose to match the atom used elsewhere for horizontal spacing, but looks like it's diverged and it lgtm so not real reason to use the atom I suppose 🤔
There was a problem hiding this comment.
oh yea, i ended up going back and forth playing w/ the value and ended up forgetting to put this back. I actually prefer to show the atom usage as it clarifies why we didn't use it (as I get more and more into the habit of using them especially). Added that back 👍
estrattonbailey
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buttons on Safari, Firefox, and Chrome - respectively.