Enable navigation animations on Android, decrease animation speed #4207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4207.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cp81ee779t8c73983js0. |
|
haileyok
changed the title
react-navigation, use ios animation, add animations back to android
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked with #4216
Why
We removed Android transition animations in #2352 because of #2308.
This reverts that change and upgrades
react-navigationto the latest stable release. It also removes the patch, since that fix was merged in and was released in 6.1.11 https://github.com/react-navigation/react-navigation/releases/tag/%40react-navigation%2Fnative%406.1.11.Testing
First, I checked out 705f9b6 which is two commits prior to the fix in #2352. I am reliably able to reproduce the issue with this change using the reproduction steps in #2308.
Next, I checked this branch out. Following the same reproduction steps does not reproduce the issue. Below are a few theories:
react-navigationthroughout the versions between our current and latest 6.X release. None specifically call out this issue, but they could be related.TouchableHighlightanimation was very janky in that old commit. The color (dimness) of the text when the post was pressed in was the same color as the next screen's text. It's possible that some combination of issues between react-navigation and theTouchableHighlightwas causing an issue.