Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable page-transition animations on android #2352

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

pfrazee
Copy link
Collaborator

@pfrazee pfrazee commented Dec 28, 2023

Closes #2308

Users have been reporting that Following/Follower pages are empty, and also that some pages are weirdly "dimmed."

I traced this to react-navigation's animations bizarrely failing to complete. Disabling them fixes it. I'm not inclined to dig deeper into the cause right now.

@pfrazee pfrazee merged commit 2a369e7 into main Dec 28, 2023
4 checks passed
@pfrazee pfrazee deleted the android-disable-page-animations branch December 28, 2023 23:46
estrattonbailey added a commit that referenced this pull request Jan 1, 2024
* origin/main: (67 commits)
  Localize options in "Thread Preferences" screen (#2373)
  Bump ios build number and android version code
  Remove the KeyboardAvoidingView in account creation (close #2333) (#2366)
  1.62
  Create account tweaks (#2365)
  Fix sizing of the leftnav new post btn (#2248)
  Use memory caching for android lightbox (#2354)
  Disable page-transition animations on android (#2352)
  Disable BlurView on android (#2351)
  Handle birth dates as UTC, handle locale formatting (#2363)
  Fix desktop styles a bit
  Disable spanish translation until it's more thoroughly reviewed (#2362)
  minor search screen ux improvements (#2264)
  Temporarily disable the german translation (#2360)
  Web dropdowns (#2358)
  Mark more text as translatable (#2284)
  Remove patched color scheme code (#2340)
  support multiple og:image tags (#2305)
  Fix missing avatar moderation in replies (#2325)
  Fixes to feed load triggers (#2323)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[APP-929] Thread screen dimming on android
2 participants