-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use custom github action for fingerprinting #4226
Conversation
Your Render PR Server URL is https://social-app-pr-4226.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cp9ubqn109ks73cqr2bg. |
|
- name: ⚙️ Install Dependencies | ||
run: yarn install | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The custom action will handle installing dependencies, since it needs to install deps from both commits. Therefore, we are removing the yarn install
step from this workflow.
The action will:
- Checkout the previous commit and install deps
- Fingerprint that commit
- Checkout the current commit and install deps
- Fingerprint the current commit
- Diff the two fingerprints
Afterwards, we will have the proper deps installed, so there is no need to install them prior to running the fingerprint action.
Why
There are a few race conditions right now with our fingerprint workflow for TestFlight/internal builds because of how the Expo fingerprint action caches previous fingerprints - and relies on those fingerprints. This results in a lot of false positives for fingerprint changes when merging PRs in quick succession.
This PR uses a custom action (found at https://github.com/bluesky-social/github-actions/tree/main/fingerprint-native) that does not use the cache.
Test Plan