Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use custom github action for fingerprinting #4226

Merged
merged 16 commits into from
May 28, 2024

Conversation

haileyok
Copy link
Contributor

@haileyok haileyok commented May 27, 2024

Why

There are a few race conditions right now with our fingerprint workflow for TestFlight/internal builds because of how the Expo fingerprint action caches previous fingerprints - and relies on those fingerprints. This results in a lot of false positives for fingerprint changes when merging PRs in quick succession.

This PR uses a custom action (found at https://github.com/bluesky-social/github-actions/tree/main/fingerprint-native) that does not use the cache.

Test Plan

  • PR - Properly detects no changes
  • PR - Properly detect a native change against main
  • PR - Properly comments on PR when change is introduced against main
  • PR - Deletes the comment whenever diff differences are removed
  • Merge/TF - Properly detects no changes
  • Merge/TF - Properly detects a native change against last TF commit
  • Production - Properly detects no changes
  • Production - Properly detects a native change against supplied tag

Copy link

render bot commented May 27, 2024

Copy link

github-actions bot commented May 27, 2024

Old size New size Diff
7.27 MB 7.27 MB 0 B (0.00%)

Comment on lines -92 to -94
- name: ⚙️ Install Dependencies
run: yarn install

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The custom action will handle installing dependencies, since it needs to install deps from both commits. Therefore, we are removing the yarn install step from this workflow.

The action will:

  1. Checkout the previous commit and install deps
  2. Fingerprint that commit
  3. Checkout the current commit and install deps
  4. Fingerprint the current commit
  5. Diff the two fingerprints

Afterwards, we will have the proper deps installed, so there is no need to install them prior to running the fingerprint action.

@haileyok haileyok marked this pull request as ready for review May 28, 2024 16:25
@haileyok haileyok merged commit 5ceb440 into main May 28, 2024
6 checks passed
@haileyok haileyok deleted the hailey/improve-github-action-fingerprint branch May 28, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants