Improve the visual clarity of labels on profiles and posts #4262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the display name; also add size variations
|
Your Render PR Server URL is https://social-app-pr-4262.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cpbk8dgcmk4c73b98tag. |
|
|
If a "blur" label is applied to a labeller's account by another labeller, and a user is subscribed to both, does the avatar in the first labeller's labels get blurred? (I know very little about React, but I like tongue twisters!) |
|
Not... in this scenario no |
gaearon
approved these changes
May 30, 2024
estrattonbailey
pushed a commit
that referenced
this pull request
May 31, 2024
* Update PostAlerts rendering to show the avi of the labeler rather than the display name; also add size variations * Update ProfileHeaderAlerts to match PostAlerts behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3677, we updated the label rendering to show the origin of labels. Unfortunately this has been extremely visually noisy, making the labels difficult to digest.
Some folks smartly suggested we just show the avatar, so that's what this PR does if it's from a 3p labeler. In other cases, it'll show the icon.
3p labelers
Baked-in labeler