Interpret 'hide' setting as ALWAYS hiding from thread replies #4263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4263.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cpbognol6cac73a8crig. |
|
gaearon
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on another PR, I noticed that we don't currently handle the "Hide" behavior correctly in thread replies.
Current behavior
The current interpretation is that "Hide" only filters replies out of feeds. This means that replies only get blurred by
blur=content. Put another way, on "badge"-style labels, the hide preference has no effect.New behavior
The new behavior ensures that a Hide preference will blur replies.