adjust notifications experiment by removing canAskAgain
#4271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4271.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cpbt34021fec73d0njng. |
haileyok
commented
May 30, 2024
|
gaearon
approved these changes
May 30, 2024
estrattonbailey
pushed a commit
that referenced
this pull request
May 31, 2024
* adjust notifications experiment by removing `canAskAgain` * move to `StepFinished` for after onboarding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
There was a significantly higher number of people hitting the
request_notifications_permission_after_onboardinggate that were not actually new signups. It looks like this may have been tied tocanAskAgainbeingtrueon some devices. Let's remove that check completely, and just skip the check ifpermissions.statusisgrantedordenied.Test Plan
We can probably do some minimal testing by flipping the gate back and forth and creating new accounts to check the Statsig logs, but I'm not certain how we can verify whether the
canAskAgainwas indeed the problem here. Might be something we just need to wait and see results for.