Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't use flexBasis on web for message post embeds #4303

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

haileyok
Copy link
Contributor

Why

Using flexBasis: 0 on web is causing messages to lose their positioning:

Screenshot 2024-05-31 at 9 33 34 AM

Test Plan

Web Tablet/Desktop

Screenshot 2024-05-31 at 10 41 21 AM

Web Mobile

Screenshot 2024-05-31 at 10 41 14 AM

Copy link

render bot commented May 31, 2024

@haileyok haileyok closed this May 31, 2024
Copy link

Old size New size Diff
7.39 MB 7.39 MB -14 B (-0.00%)

Copy link

render bot commented Jun 3, 2024

@estrattonbailey estrattonbailey merged commit f05aebf into main Jun 3, 2024
6 checks passed
@haileyok haileyok deleted the hailey/web-dm-embed-style branch September 2, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants