Unify profile tabs and lists screens placeholders #4315
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Spotted that profile tabs and lists screen placeholders appearance varies.
Also wanted to address an additional border on mobile platforms when refreshing an empty feed.
How
Reuse
EmptyState
component inside profile tabs feeds and lists screen as a placeholder content. Go through all places which used the component before, to make sure that result after changes matches the appearance on PROD. Preform minor spacing tweaks.I have also spotted that
EmptyState
relies on FA icons, with one custom icon introduced. I was wondering if similar exception should be done for "Feeds" and "Lists" placeholder icons to match them with one used in the drawer, but for the sake of changeset simplicity I have left it as-is. Happy to made an update or follow up PR, if you think it would a better for the presentation.Preview