Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify profile tabs and lists screens placeholders #4315

Conversation

Simek
Copy link
Contributor

@Simek Simek commented Jun 1, 2024

Why

Spotted that profile tabs and lists screen placeholders appearance varies.

Also wanted to address an additional border on mobile platforms when refreshing an empty feed.

How

Reuse EmptyState component inside profile tabs feeds and lists screen as a placeholder content. Go through all places which used the component before, to make sure that result after changes matches the appearance on PROD. Preform minor spacing tweaks.

I have also spotted that EmptyState relies on FA icons, with one custom icon introduced. I was wondering if similar exception should be done for "Feeds" and "Lists" placeholder icons to match them with one used in the drawer, but for the sake of changeset simplicity I have left it as-is. Happy to made an update or follow up PR, if you think it would a better for the presentation.

Preview

Screenshot 2024-06-01 at 17 19 55

Screenshot 2024-06-01 at 17 47 21

Copy link
Contributor

@haileyok haileyok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

We're working our way through removing FontAwesome, so these icons are fine! Good spot.

@haileyok haileyok merged commit 44670c7 into bluesky-social:main Jun 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants