fix top border width for user list updates #4340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
invert check use `ViewHeader` simplify replace with hairline width fix top border width for user list updates
|
Your Render PR Server URL is https://social-app-pr-4340.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cpf51btds78s73e8nrmg. |
gaearon
approved these changes
Jun 3, 2024
Bad screenshot in the main comment, doesn't show the border between items. Here's what it actually looks like. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
While reviewing #4315, I noticed a couple of existing nits to clean up:
borderTopWidth: 1instead ofhairlinein the add/remove users to list screenDonebutton was also using1instead ofhairline.Before
After
See Below