Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐴] Use recent convos for share via dialog #4352

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Conversation

estrattonbailey
Copy link
Member

@estrattonbailey estrattonbailey commented Jun 4, 2024

Conditionally prepends recent convo user to beginning of Share Via DM dialog list, instead of just follows. Follows fill in remaining slots, and no change to search functionality. New Chat dialog is unchanged.

This uses the existing list convos query, which should be cached by the time this loads. So even though it loads the last 50 convos, we should be ok to put them all in there.

Copy link

render bot commented Jun 4, 2024

Copy link

github-actions bot commented Jun 4, 2024

Old size New size Diff
7.4 MB 7.4 MB 725 B (0.01%)

Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh yea this is great

@gaearon gaearon merged commit a49fe13 into main Jun 4, 2024
6 checks passed
@gaearon gaearon deleted the dms/share-via branch June 4, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants