Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add types for desktopFixedHeight to List #4356

Merged
merged 3 commits into from
Jun 5, 2024
Merged

Conversation

haileyok
Copy link
Contributor

@haileyok haileyok commented Jun 4, 2024

Let's stop requiring @ts-ignore for this prop in our List implementation

Copy link

render bot commented Jun 4, 2024

@haileyok
Copy link
Contributor Author

haileyok commented Jun 4, 2024

Oh, actually need to look closer. In Views.web.tsx it's typed as boolean | number

Huh, it's just used as a boolean in List.web.tsx.

@gaearon
Copy link
Collaborator

gaearon commented Jun 4, 2024

I never implemented it for web actually. I think it's maybe used for native?

@gaearon
Copy link
Collaborator

gaearon commented Jun 4, 2024

I'm not sure what it's really supposed to be doing. I think feeds use it.

Copy link

github-actions bot commented Jun 4, 2024

Old size New size Diff
7.4 MB 7.4 MB 0 B (0.00%)

@haileyok
Copy link
Contributor Author

haileyok commented Jun 4, 2024

Yea, the FlatList_INTERNAL applies styles accordingly if it's a number, but that makes the prop name a little confusing. I'll have to look through later to see why it gets used on native or if it even does. I don't see where it ever actually gets used in that way on native anyway 🤔

I see that desktopFixedHeightOffset is a prop for Feed, but it never gets used either as far as I can tell?

Screenshot 2024-06-04 at 11 42 22 AM

@haileyok
Copy link
Contributor Author

haileyok commented Jun 5, 2024

Will leave number as well for now, but made a note to revisit this and remove number if possible. Seems fine, though want to give it a more solid pass before assuming that's true.

@haileyok haileyok merged commit af2aaa1 into main Jun 5, 2024
6 checks passed
@haileyok haileyok deleted the hailey/type-desktop-fixed branch June 8, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants