Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show profile labels until loaded #4357

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Don't show profile labels until loaded #4357

merged 1 commit into from
Jun 4, 2024

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Jun 4, 2024

Fixes the loading sequence to avoid shifting layout.

After this change, labels are only displayed when the stuff above them is also ready.

Review sans whitespace

Before

before.mov

After

after.mov

Copy link

render bot commented Jun 4, 2024

@gaearon gaearon merged commit b5ac450 into main Jun 4, 2024
6 checks passed
@gaearon gaearon deleted the skip-label-load branch June 4, 2024 18:54
Copy link

github-actions bot commented Jun 4, 2024

Old size New size Diff
7.4 MB 7.4 MB -91 B (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants