Create a testable version of ago() and re-enable the disabled test #4364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This puts the input and the expected values next to each other.
This is a copy of ago(), but with the ability to specify the second date instead of using Date.now().
This makes it possible to test the dates without being forced to rely on what the current date is. The commented out tests do not yet pass. This is fixed in later commits.
janaagaard75
changed the title
estrattonbailey
approved these changes
Jun 17, 2024
estrattonbailey
added a commit
that referenced
this pull request
Jun 18, 2024
* Create a testable version of ago() and re-enable the disabled test (#4364) * Enable the test of ago() * Use test cases This puts the input and the expected values next to each other. * Create dateDiff function This is a copy of ago(), but with the ability to specify the second date instead of using Date.now(). * Let ago() use dateDiff() * Move constants close to usage * Test dateDiff instead of ago This makes it possible to test the dates without being forced to rely on what the current date is. The commented out tests do not yet pass. This is fixed in later commits. * Update dateDiff and enable the remaining tests * Split up tests, use date-fns as helpers * Remove old test * Add long format * Add hook * Migrate to hooks * Delete old code * Or equal to * Update comment --------- Co-authored-by: Jan Aagaard <jan@aagaard.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current tests for ago() function are not deterministic, so they are currently disabled.
Create a testable version of ago(), dateDiff(), that has two parameter, allowing for deterministic tests. ago() is then implemented as a special case of dateDiff(), where one of the dates is
new Date().The implementation is changed so that months are now considered to a fixed 30 days instead of the current 30.41675 days. Using 30 days is arguably less precise, but it is a lot easier to reason about because the cut off from month to month is always a full day. I think this simpler solution was preferable. The root cause of the mess is that "a month ago" means a different number of days depending the current month.
This follows up on #4295.