Fix undefined block #4378
Merged
Fix undefined block #4378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/view/com/posts/FeedItem.tsx
Outdated
| @@ -196,6 +196,12 @@ let FeedItemInner = ({ | |||
| }, | |||
| ] | |||
|
|
|||
| let blockedParentAuthor: AppBskyActorDefs.ProfileViewBasic = { | |||
| did: '', | |||
| displayName: '[user blocked you]', | |||
There was a problem hiding this comment.
If I block this user instead of them blocking me, this text might be confusing. Should probably do something more generic like [blocked user] and then checking for all forms of blocks on the viewer state when displaying it:
blockedBy?: boolean
blocking?: string
blockingByList?: AppBskyGraphDefs.ListViewBasic
There was a problem hiding this comment.
I'm home in 30m and will adjust this then :)
|
@estrattonbailey Thanks for letting me know! I didn't know 
|
estrattonbailey
approved these changes
Jun 11, 2024
estrattonbailey
added a commit
that referenced
this pull request
Jun 11, 2024
* Fix undefined block (#4378) * Fix undefined block * Changing text and handling all blocks. * Tweaks * Hide follow button in hover card if user blocked --------- Co-authored-by: Josh <hi@oracularhades.com>
gaearon
added a commit
that referenced
this pull request
Jun 18, 2024
* Fix undefined block (#4378) * Fix undefined block * Changing text and handling all blocks. * Tweaks * Update copy, make non-interactive * Remove console * Clarify logic * Pass through parent blocked state for 3p blocks * Better translation --------- Co-authored-by: Josh <hi@oracularhades.com> Co-authored-by: Dan Abramov <dan.abramov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #4322
Screen.Recordingundefined-block-fix.mp4