Switch to withSpring to work around Reanimated regression #4391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4391.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cpgr0m6v3ddc73ecmp9g. |
|
mozzius
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we switched from Reanimated 3.6 to 3.11, scrolling on Home has gotten incredibly choppy. @haileyok and I narrowed it down to this animated value — it's being set to both plain numbers and to
withTiming, and for some reason it appears that doing both (or maybe even justwithTimingby itself) makes it choppy even after the animation has completed (i.e. while scrolling later). It seems likewithSpringdoesn't have this problem so this just switches us to do that.I've looked at other places where we have
withTimingand they don't seem negatively affected so I didn't touch it.Test Plan
Scroll Home feed on low-end Android. It was super choppy before, now it's okay (with some dropped frames).