Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lightbox on Android for tall images #4393

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Jun 6, 2024

Tall images didn't fully fit due to a flawed calculation.

I'm not sure why the new calculation makes sense or when it regressed but it does appear to have correct results.

Before

fix_before.mov

After

fix_after.mov

Copy link

render bot commented Jun 6, 2024

Copy link

github-actions bot commented Jun 6, 2024

Old size New size Diff
7.39 MB 7.39 MB 0 B (0.00%)

@gaearon gaearon merged commit 5597641 into main Jun 6, 2024
6 checks passed
@gaearon gaearon deleted the fix-android-image-h branch June 6, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants