Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary Android code #4429

Closed
wants to merge 1 commit into from
Closed

Remove unnecessary Android code #4429

wants to merge 1 commit into from

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Jun 8, 2024

Seems unnecessary after #4427, let's remove to simplify.

Tested on my device, would be nice to test on more.

Copy link

render bot commented Jun 8, 2024

@gaearon gaearon requested review from mozzius and haileyok June 8, 2024 13:34
Copy link

github-actions bot commented Jun 8, 2024

Old size New size Diff
7.39 MB 7.39 MB -37 B (-0.00%)

@haileyok
Copy link
Contributor

haileyok commented Jun 8, 2024

Seems fine, will test more in a bit. Should we also remove the isModalReady state and reactions from shell/Composer.tsx?

@gaearon
Copy link
Collaborator Author

gaearon commented Jun 18, 2024

not relevant anymore

@gaearon gaearon closed this Jun 18, 2024
@gaearon gaearon deleted the android-fix-more branch June 18, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants