Reliably focus keyboard on Android #4427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4427.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cphu34acn0vc73c5f4i0. |
|
haileyok
approved these changes
Jun 8, 2024
There was a problem hiding this comment.
Tested on 3 devices from high to low end (lowest being a 2017 device). Keyboard presents in all cases and is generally smoother than before. This feels good as a guarantee that we don't run into problems. We should still revisit at some point I think but this is much more solid than what we currently have.
haileyok
pushed a commit
that referenced
this pull request
Jun 8, 2024
(cherry picked from commit a2d1cf6)
| function tryFocus() { | ||
| if (!Keyboard.isVisible()) { | ||
| textInput.current?.blur() | ||
| textInput.current?.focus() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My best attempt at making it work based on a real device. Requires some testing.