-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Japanese translation #4477
Conversation
前回PR #4311 の追加箇所ですみませんが、「モーダル」が通じにくいのではないかと思いました。良さそうな言いかえはあるでしょうか? |
モーダルの訳語、適切なものが思いつきません。モーダルダイアログ、のように略せずフルの単語で書くくらいでしょうか。 |
モーダルの訳語難しいですね、「モーダルダイアログ」以外だと「モーダルウィンドウ」などでしょうか。 |
「ダイアログ」としてしまうか、分かりやすさ優先で「ポップアップ」としてしまうか、という感じでしょうか。 |
ポップアップとモーダルは動作が違う(ポップアップは背後のUIも操作可能、モーダルは操作不能)ので、訳語は統一しないほうがいいかな、と思います。 |
「site:support.apple.com inurl:ja-JP "モーダル"」で検索したり、 https://developer.mozilla.org/ja/docs/Web/HTML/Element/dialog を見ても、「モーダル」が一般的なようなので、このままにしておきます。 |
translated messages related to social-proof, etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your working!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the translation, this change looks good.
and I'd be happy to include the omission that I couldn't reflect last time.
#4311 (comment)
@dolciss forgot to fix this. thanks! |
LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks all!
@Hima-Zinn @dolciss @oboenikui @noritada @middlingphys @hibiki @reindex-ot @haoyayoi @vyv03354
Please review!