Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Japanese translation #4477

Merged
merged 11 commits into from
Jun 20, 2024
Merged

Conversation

tkusano
Copy link
Contributor

@tkusano tkusano commented Jun 11, 2024

@middlingphys
Copy link
Contributor

前回PR #4311 の追加箇所ですみませんが、「モーダル」が通じにくいのではないかと思いました。良さそうな言いかえはあるでしょうか?

@tkusano
Copy link
Contributor Author

tkusano commented Jun 11, 2024

モーダルの訳語、適切なものが思いつきません。モーダルダイアログ、のように略せずフルの単語で書くくらいでしょうか。

@hibiki
Copy link
Contributor

hibiki commented Jun 11, 2024

モーダルの訳語難しいですね、「モーダルダイアログ」以外だと「モーダルウィンドウ」などでしょうか。
似たものだとポップアップウィンドウがありますが、モーダルとは少し意味合い違う気もしています

@middlingphys
Copy link
Contributor

「ダイアログ」としてしまうか、分かりやすさ優先で「ポップアップ」としてしまうか、という感じでしょうか。
言いかえがしっくりこないならそのままの方が良いかもしれません。

@tkusano
Copy link
Contributor Author

tkusano commented Jun 12, 2024

ポップアップとモーダルは動作が違う(ポップアップは背後のUIも操作可能、モーダルは操作不能)ので、訳語は統一しないほうがいいかな、と思います。

@tkusano
Copy link
Contributor Author

tkusano commented Jun 12, 2024

Wait PR #4493 #4494 is merged before updating translation

@tkusano
Copy link
Contributor Author

tkusano commented Jun 12, 2024

「site:support.apple.com inurl:ja-JP "モーダル"」で検索したり、 https://developer.mozilla.org/ja/docs/Web/HTML/Element/dialog を見ても、「モーダル」が一般的なようなので、このままにしておきます。

@tkusano
Copy link
Contributor Author

tkusano commented Jun 12, 2024

translated messages related to social-proof, etc.

Copy link
Contributor

@Hima-Zinn Hima-Zinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your working!

@tkusano
Copy link
Contributor Author

tkusano commented Jun 13, 2024

Updated Japanese translation

  • KnownFollowers localization 7faa1d9
  • Fix profile hover card blocked state 28ba999

Copy link
Contributor

@dolciss dolciss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the translation, this change looks good.
and I'd be happy to include the omission that I couldn't reflect last time.
#4311 (comment)

@tkusano
Copy link
Contributor Author

tkusano commented Jun 13, 2024

@dolciss forgot to fix this. thanks!

@dolciss
Copy link
Contributor

dolciss commented Jun 13, 2024

LGTM!

@tkusano
Copy link
Contributor Author

tkusano commented Jun 17, 2024

Updated translations

In one place "my feeds" was not translated as "マイフィード".

@tkusano
Copy link
Contributor Author

tkusano commented Jun 19, 2024

Add new translations

  • Add useGetTimeAgo and utils 443beda
  • Bump labeler limit to 20 853c32b

etc.

@pfrazee pfrazee self-assigned this Jun 20, 2024
Copy link
Collaborator

@pfrazee pfrazee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks all!

@pfrazee pfrazee merged commit 8ff8627 into bluesky-social:main Jun 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants