Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix button hover color #4492

Merged

Conversation

quiple
Copy link
Contributor

@quiple quiple commented Jun 12, 2024

  • Makes the ProfileMenu button in the ProfileHeader change color based on mouse over.

    • Before:
      Video_1.mp4
    • After:
      Video_2.mp4
  • Match the hover color of the other buttons to the other parts. And Match the icon to the ProfileMenu button.

    • Before:
      2024-06-15.14.27.14.mov
    • After:
      2024-06-15.14.33.18.mov
  • Match the hover color of the ghost button accordingly.

    • Before:
      2024-06-15.14.37.55.mov
    • After:
      2024-06-15.14.38.29.mov

@quiple quiple changed the title Hover color on ProfileMenu button Fix button hover color Jun 15, 2024
Copy link
Member

@estrattonbailey estrattonbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, thank you

@estrattonbailey estrattonbailey changed the base branch from main to eric/merge-4492 June 20, 2024 15:31
@estrattonbailey estrattonbailey merged commit 457c32a into bluesky-social:eric/merge-4492 Jun 20, 2024
6 checks passed
pfrazee pushed a commit that referenced this pull request Jun 20, 2024
* Fix button hover color (#4492)

* Update ProfileMenu.tsx

* Update Button.tsx

* Update ProfileFeed.tsx

* Update ProfileFeed.tsx

* Re-add change post conflict

---------

Co-authored-by: Minseo Lee <itoupluk427@gmail.com>
estrattonbailey added a commit that referenced this pull request Jun 20, 2024
* origin/main: (25 commits)
  Add a11y context (#4586)
  center pill text in label pill (#4579)
  Wait for AppView when posting (#4584)
  Bsky link card service (#4547)
  Merge #4492, fixes profile menu hover (#4580)
  Rework "Who can reply" to blend more nicely into the UI (#4578)
  Fix threadgate read after write (#4577)
  Convert button to use forwardRef (#4576)
  use 1000x1000 for image height in avatar cropper (#4453)
  fix for autofill covering border (#4573)
  Update HomeHeaderLayoutMobile.tsx (#4572)
  Option for large alt badges (#4571)
  Truncate post metrics and fix truncation on native (#4575)
  Fix avi placeholder layout (#4570)
  add support for `ListEmptyComponent`, allow `undefined` data (#4403)
  GIF previews in notifications (#4447)
  [Session] Convert account to session data explicitly (#4446)
  Move onboarding start to after successfull account creation (#4381)
  Collection of moderation fixes (#4566)
  Fix undefined block (#4479)
  ...
@quiple quiple deleted the ellipsis-hover-color branch June 21, 2024 00:00
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants