Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for autofill covering border #4573

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Fix for autofill covering border #4573

merged 1 commit into from
Jun 19, 2024

Conversation

mozzius
Copy link
Member

@mozzius mozzius commented Jun 19, 2024

Scoped to web only. Adds 2px of margin to the top and bottom of the text input so that it doesn't cover the border, and reduces padding by that amount

Before (ff) After (ff) Before (chrome) After (chrome)
Screenshot 2024-06-19 at 19 20 34 Screenshot 2024-06-19 at 19 20 24 Screenshot 2024-06-19 at 19 21 50 Screenshot 2024-06-19 at 19 21 21

Copy link

render bot commented Jun 19, 2024

Copy link

Old size New size Diff
6.3 MB 6.3 MB 64 B (0.00%)

@gaearon gaearon merged commit 5c31859 into main Jun 19, 2024
6 checks passed
@gaearon gaearon deleted the samuel/autofill branch June 19, 2024 22:42
estrattonbailey added a commit that referenced this pull request Jun 19, 2024
* origin/main:
  Convert button to use forwardRef (#4576)
  use 1000x1000 for image height in avatar cropper (#4453)
  fix for autofill covering border (#4573)
estrattonbailey added a commit that referenced this pull request Jun 20, 2024
* origin/main: (62 commits)
  Rework "Who can reply" to blend more nicely into the UI (#4578)
  Fix threadgate read after write (#4577)
  Convert button to use forwardRef (#4576)
  use 1000x1000 for image height in avatar cropper (#4453)
  fix for autofill covering border (#4573)
  Update HomeHeaderLayoutMobile.tsx (#4572)
  Option for large alt badges (#4571)
  Truncate post metrics and fix truncation on native (#4575)
  Fix avi placeholder layout (#4570)
  add support for `ListEmptyComponent`, allow `undefined` data (#4403)
  GIF previews in notifications (#4447)
  [Session] Convert account to session data explicitly (#4446)
  Move onboarding start to after successfull account creation (#4381)
  Collection of moderation fixes (#4566)
  Fix undefined block (#4479)
  fix gap between tab bar and its border (#4538)
  Better handling of blocks in `KnownFollowers` (#4563)
  Verify email reminders (#4510)
  Bump labeler limit to 20 (#4565)
  Migrate local thread mutes (#4523)
  ...
estrattonbailey added a commit that referenced this pull request Jun 20, 2024
* origin/main: (25 commits)
  Add a11y context (#4586)
  center pill text in label pill (#4579)
  Wait for AppView when posting (#4584)
  Bsky link card service (#4547)
  Merge #4492, fixes profile menu hover (#4580)
  Rework "Who can reply" to blend more nicely into the UI (#4578)
  Fix threadgate read after write (#4577)
  Convert button to use forwardRef (#4576)
  use 1000x1000 for image height in avatar cropper (#4453)
  fix for autofill covering border (#4573)
  Update HomeHeaderLayoutMobile.tsx (#4572)
  Option for large alt badges (#4571)
  Truncate post metrics and fix truncation on native (#4575)
  Fix avi placeholder layout (#4570)
  add support for `ListEmptyComponent`, allow `undefined` data (#4403)
  GIF previews in notifications (#4447)
  [Session] Convert account to session data explicitly (#4446)
  Move onboarding start to after successfull account creation (#4381)
  Collection of moderation fixes (#4566)
  Fix undefined block (#4479)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants