[Session] Convert account to session data explicitly #4446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4446.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cpipbqect0pc73feo380. |
|
estrattonbailey
added a commit
that referenced
this pull request
Jun 20, 2024
* origin/main: (62 commits) Rework "Who can reply" to blend more nicely into the UI (#4578) Fix threadgate read after write (#4577) Convert button to use forwardRef (#4576) use 1000x1000 for image height in avatar cropper (#4453) fix for autofill covering border (#4573) Update HomeHeaderLayoutMobile.tsx (#4572) Option for large alt badges (#4571) Truncate post metrics and fix truncation on native (#4575) Fix avi placeholder layout (#4570) add support for `ListEmptyComponent`, allow `undefined` data (#4403) GIF previews in notifications (#4447) [Session] Convert account to session data explicitly (#4446) Move onboarding start to after successfull account creation (#4381) Collection of moderation fixes (#4566) Fix undefined block (#4479) fix gap between tab bar and its border (#4538) Better handling of blocks in `KnownFollowers` (#4563) Verify email reminders (#4510) Bump labeler limit to 20 (#4565) Migrate local thread mutes (#4523) ...
estrattonbailey
added a commit
that referenced
this pull request
Jun 20, 2024
* origin/main: (25 commits) Add a11y context (#4586) center pill text in label pill (#4579) Wait for AppView when posting (#4584) Bsky link card service (#4547) Merge #4492, fixes profile menu hover (#4580) Rework "Who can reply" to blend more nicely into the UI (#4578) Fix threadgate read after write (#4577) Convert button to use forwardRef (#4576) use 1000x1000 for image height in avatar cropper (#4453) fix for autofill covering border (#4573) Update HomeHeaderLayoutMobile.tsx (#4572) Option for large alt badges (#4571) Truncate post metrics and fix truncation on native (#4575) Fix avi placeholder layout (#4570) add support for `ListEmptyComponent`, allow `undefined` data (#4403) GIF previews in notifications (#4447) [Session] Convert account to session data explicitly (#4446) Move onboarding start to after successfull account creation (#4381) Collection of moderation fixes (#4566) Fix undefined block (#4479) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously suppressing a type error which was a legit mismatch in types. We were assigning
SessionAccount(an app concept) directly intoagent.sessionas if it wereAtpSessionData.Strictly saying, this isn't valid — for example,
refreshJwtcan beundefinedinSessionAcountbut is expected to be astring(even if empty) inAtpSessionData. We do have a check (per suppression comment) that should rule out this actually happening but I think it's better to ensure this statically. This also avoids unrelated account fields likepdsUrlending up attached to thesessionobject.This PR removes the suppression and adds an explicit conversion based on existing logic from the resume session codepath.
I don't expect this to change anything in practice.
Test Plan
Idk how to test this since it needs to trigger expiry. I think we need support from backend to force early expiry — with a header or something. So for now the test plan is just careful reading.