Use a 1:1 ratio for avatar cropper #4453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4453.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cpj8cgkf7o1s73f391o0. |
|
haileyok
changed the title
estrattonbailey
added a commit
that referenced
this pull request
Jun 20, 2024
* origin/main: (62 commits) Rework "Who can reply" to blend more nicely into the UI (#4578) Fix threadgate read after write (#4577) Convert button to use forwardRef (#4576) use 1000x1000 for image height in avatar cropper (#4453) fix for autofill covering border (#4573) Update HomeHeaderLayoutMobile.tsx (#4572) Option for large alt badges (#4571) Truncate post metrics and fix truncation on native (#4575) Fix avi placeholder layout (#4570) add support for `ListEmptyComponent`, allow `undefined` data (#4403) GIF previews in notifications (#4447) [Session] Convert account to session data explicitly (#4446) Move onboarding start to after successfull account creation (#4381) Collection of moderation fixes (#4566) Fix undefined block (#4479) fix gap between tab bar and its border (#4538) Better handling of blocks in `KnownFollowers` (#4563) Verify email reminders (#4510) Bump labeler limit to 20 (#4565) Migrate local thread mutes (#4523) ...
estrattonbailey
added a commit
that referenced
this pull request
Jun 20, 2024
* origin/main: (25 commits) Add a11y context (#4586) center pill text in label pill (#4579) Wait for AppView when posting (#4584) Bsky link card service (#4547) Merge #4492, fixes profile menu hover (#4580) Rework "Who can reply" to blend more nicely into the UI (#4578) Fix threadgate read after write (#4577) Convert button to use forwardRef (#4576) use 1000x1000 for image height in avatar cropper (#4453) fix for autofill covering border (#4573) Update HomeHeaderLayoutMobile.tsx (#4572) Option for large alt badges (#4571) Truncate post metrics and fix truncation on native (#4575) Fix avi placeholder layout (#4570) add support for `ListEmptyComponent`, allow `undefined` data (#4403) GIF previews in notifications (#4447) [Session] Convert account to session data explicitly (#4446) Move onboarding start to after successfull account creation (#4381) Collection of moderation fixes (#4566) Fix undefined block (#4479) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Avatar cropping on Android is not great right now, since the current logic requires the new image be the same size as whatever the input is. For example, a 3000x1500 input will expect an image of that same aspect when cropping. This doesn't work very well for avatar crops.
Screen.Recording.2024-06-09.at.9.44.56.PM.mov
How
Instead of using the input picture's height and width, we should just set this to a size with equal height and width. We'll use 1000x1000 for now. This ends up allowing us to crop to whatever region of the photo we want.
Screen.Recording.2024-06-09.at.9.45.53.PM.mov
Test Plan
RocketSim_Recording_iPhone_15_Pro_Max_6.7_2024-06-09_21.48.21.mp4
Screen.Recording.2024-06-09.at.9.50.20.PM.mov