DRY up popular feeds query #4501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4501.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cpl39ntjm4es739c5ahg. |
estrattonbailey
commented
Jun 12, 2024
| !popularFeeds?.pages || | ||
| popularFeeds?.pages[0]?.feeds?.length === 0 | ||
| ) { | ||
| if (!popularFeeds?.pages) { |
There was a problem hiding this comment.
First page can be empty, but subsequent pages will have results
|
Merged
pfrazee
approved these changes
Jun 14, 2024
gaearon
reviewed
Jun 17, 2024
| data: InfiniteData<AppBskyUnspeccedGetPopularFeedGenerators.OutputSchema>, | ||
| ) => { | ||
| const {savedFeeds, hasSession: hasSessionInner} = selectArgs | ||
| data?.pages.map(page => { |
There was a problem hiding this comment.
This is a mutation so it's not really selecting. Why is that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The popular feeds query returns a static list of feeds. Some are not available logged out, and it returns feeds even if you've already pinned them. We had logic on the Feeds screen to filter based on session state and by which feeds you have saved.
I needed to reuse the same logic in #4491 and seemed like we could push this logic into the query handler itself.
This means that the popular feeds query will now return results with the feeds you've saved filtered out. We don't use this for anything else at the moment, and if we do need this, it'd be easy enough to add a param to this query to conditionally filter.
The only semi-noticeable change that this PR introduces is over-fetching if the first page of results doesn't return enough feeds that aren't already pinned. It reuses the exact pattern we used in
post-feedto accomplish this. This will be used on the Explore page to show ~3 feeds on the first page of results, but that first page is likely to contain some feeds the user already has pinned, thus the need for over-fetching to ensure we get at least 3 (it may be more e.g. 5 if first page has 2 un-pinned feeds and second page has a full 3).