Fix crash in Feeds and Starter Packs #4616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4616.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cpssu33v2p9s73f4hnf0. |
gaearon
commented
Jun 24, 2024
| : savedFeeds.concat( | ||
| popularFeeds.filter(f => !savedFeeds.some(sf => sf.uri === f.uri)), | ||
| ) | ||
| const suggestedFeeds = savedFeeds.concat( |
There was a problem hiding this comment.
Not essential to the fix, but this wasn't doing anything and made the code more complicated.
gaearon
commented
Jun 24, 2024
| }) | ||
| } else if (savedItem.type === 'feed') { | ||
| const resolvedFeed = resolvedFeeds.get(savedItem.value) | ||
| if (resolvedFeed) { |
gaearon
commented
Jun 24, 2024
| } | ||
| } else if (savedItem.type === 'list') { | ||
| const resolvedList = resolvedLists.get(savedItem.value) | ||
| if (resolvedList) { |
gaearon
commented
Jun 24, 2024
| ? resolvedFeeds.get(s.value) | ||
| : resolvedLists.get(s.value), | ||
| } | ||
| }) as SavedFeedItem[] |
There was a problem hiding this comment.
This was covering up the mistake.
gaearon
changed the title
estrattonbailey
approved these changes
Jun 24, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See inline comments.
Test Plan
Add
throw Error('no')here, then add it here. In both cases the Feeds page should be able to recover, and show the rest instead. Similarly start pack creation should recover in both cases.