Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable facets in FeedCard.Description component #4620

Merged
merged 4 commits into from
Jun 25, 2024
Merged

Conversation

estrattonbailey
Copy link
Member

@estrattonbailey estrattonbailey commented Jun 24, 2024

This PR disables links within FeedCard.Description. It does run detectFacetsWithoutResolution so that URLs look nice.

If we ever have need for them, we can add another export here called like DescriptionWithFacets, sorta like the first commit in this PR.

Copy link

render bot commented Jun 24, 2024

Copy link

github-actions bot commented Jun 24, 2024

Old size New size Diff
6.47 MB 6.47 MB 95 B (0.00%)

@estrattonbailey estrattonbailey marked this pull request as draft June 24, 2024 23:39
@estrattonbailey
Copy link
Member Author

Wait one sec

@estrattonbailey estrattonbailey changed the title Disable feed description facets on starter pack lander Disable facets in FeedCard.Description component Jun 24, 2024
@estrattonbailey estrattonbailey marked this pull request as ready for review June 24, 2024 23:53
@haileyok haileyok merged commit 6cda641 into main Jun 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants