FeedCard & ListCard cleanups #4644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4644.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cptle5mehbks73fdl4f0. |
|
pfrazee
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
FeedCarda bit and extracts aListCardcomponent for easier usage in either case. If you're rendering a feed, useFeedCard. List, useListCard.ListCardinherits fromFeedCard, since they're very similar, but I think the clarity of usage like this makes this pattern worth it. If we need to further differentiate in the future we can pretty easily like this. Examples:LikescomponentSubscribeButtonTitleAndBylineneeds apurposefor lists, but not for feedstypeorpurposefield for feeds 👀