Better starterpack embed #4659
Merged
Better starterpack embed #4659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4659.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cpu9ahiju9rs73fbp7dg. |
|
haileyok
commented
Jun 27, 2024
|
|
||
| export async function resolveShortLink(shortLink: string) { | ||
| const controller = new AbortController() | ||
| const to = setTimeout(() => controller.abort(), 2e3) |
There was a problem hiding this comment.
these should resolve in two seconds, but we can bump to maybe 5 if we need to.
pfrazee
approved these changes
Jun 27, 2024
estrattonbailey
added a commit
that referenced
this pull request
Jun 27, 2024
* origin/main: bskyogcard: support emoji, more languages, long starter pack names (#4668) Run intl extract Add some events to landing screen (#4664) update follows when pressing follow all (#4663) Better starterpack embed (#4659) [Starter Packs] Posts tab (#4660) Run intl extract [D1X] Onboarding interest display names (#4657) Mark two starter pack strings for localization (#4655) Refactor nested conditions in the starter pack wizard (#4652)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
without whitespace
Temporarily using an external embed for this. The app view is actually returning a
NotFoundrecord for these, so the normal way of embedding a record won't do great. The image being displayed keeps the info fresh though.Will add go.bsky.app resolution in a separate PR.
Note: resolution won't work on localhost, because of the origin header. Has to be on a bsky.app domain.