Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[D1X] Integrate interstitials #4698

Merged
merged 5 commits into from
Jul 3, 2024
Merged

[D1X] Integrate interstitials #4698

merged 5 commits into from
Jul 3, 2024

Conversation

estrattonbailey
Copy link
Member

@estrattonbailey estrattonbailey commented Jun 28, 2024 •
edited
Loading

Stacked on #4697

Inserts interstitials in Discover and Following:

  • Discover: adds a suggested feeds at 20 posts, and followers at 40
  • Following: adds followers at 20 posts, and feeds at 40

Testing:
Add you ID to StatSig overrides.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 28, 2024 •
edited
Loading

Old size New size Diff
6.5 MB 6.5 MB 0 B (0.00%)

@estrattonbailey estrattonbailey changed the title Integrate interstitials [D1X] Integrate interstitials Jun 28, 2024
pfrazee
pfrazee approved these changes Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@pfrazee pfrazee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested yet but at a glance this looks solid

@estrattonbailey estrattonbailey marked this pull request as ready for review July 1, 2024 16:10
@estrattonbailey estrattonbailey force-pushed the integrate-interstitials branch from 02e8851 to 63710af Compare July 1, 2024 21:44
@estrattonbailey estrattonbailey marked this pull request as draft July 1, 2024 22:04
@estrattonbailey estrattonbailey marked this pull request as ready for review July 1, 2024 23:40
@estrattonbailey estrattonbailey requested a review from gaearon July 1, 2024 23:40
@gaearon gaearon changed the base branch from feed-interstitials to main July 3, 2024 02:34
@gaearon gaearon changed the base branch from main to feed-interstitials July 3, 2024 02:38
@gaearon gaearon changed the base branch from feed-interstitials to main July 3, 2024 02:40
@gaearon gaearon force-pushed the integrate-interstitials branch from 02b3ac5 to d39770a Compare July 3, 2024 02:40
@render Render
Copy link

render bot commented Jul 3, 2024

Your Render PR Server URL is https://social-app-pr-4698.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-cq2bk8uehbks73f6dgeg.

@gaearon gaearon merged commit 04cfd06 into main Jul 3, 2024
6 checks passed
@gaearon gaearon deleted the integrate-interstitials branch July 3, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfrazee pfrazee pfrazee approved these changes

@gaearon gaearon gaearon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@estrattonbailey @gaearon @pfrazee