Add starter pack embeds to posts #4699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4699.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cpvgtalds78s73fbfe5g. |
|
haileyok
force-pushed
the
hailey/better-sp-embeds
branch
from
8f9d38e to
e75233e
Compare
gaearon
reviewed
Jul 3, 2024
| @@ -104,14 +110,42 @@ export function Link({ | |||
| } | |||
|
|
|||
| return ( | |||
| <InternalLink | |||
There was a problem hiding this comment.
I think we actually want to keep this a link. E.g. cmd+click should open in new tab. Any reason for this change?
gaearon
requested changes
Jul 3, 2024
haileyok
added a commit
that referenced
this pull request
Jul 7, 2024
* starter pack embeds * revert test code * Types * add `BaseLink` * precache on click * rm log * add a comment * loading state * top margin --------- Co-authored-by: Dan Abramov <dan.abramov@gmail.com> (cherry picked from commit aa7117e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on bluesky-social/atproto#2613 being deployed or using dev env from that branch.
Note that these will work with
go.bsky.applinks as well, though those records wouldn't work in the local dev env. Once ^ gets deployed we should just test again to make sure.Web
Native