Ensure /start navigates to /starter-pack when clicking a link internally
#4745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4745.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cq52jkiju9rs73alttv0. |
|
gaearon
approved these changes
Jul 7, 2024
estrattonbailey
added a commit
that referenced
this pull request
Jul 9, 2024
…cial-proof * origin/main: (126 commits) Update README.md (#4394) tweak top padding external (#4755) change `contentVisibility` to `contain` (#4752) Fix RTL text rendering for display names (#4747) Reduce the size of the inner logo in the QR code (#4746) Fix misplaced '@' in RTL post meta. (#4531) Remove broken and void back button (#4744) Ensure `/start` navigates to `/starter-pack` when clicking a link internally (#4745) Add missing `to` in StarterPackScreen.tsx string (#4743) Video compression in composer (#4638) fix slop (#4739) Update stats Run intl:extract Update Japanese translation (#4665) Update Korean localization (#4646) Update Chinese Localization (#4695) Update catalan (#4702) Update Indonesian translation (#4706) Tweak checkmark size Show feedback for Follow button in interstitials (#4738) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
without whitespace
Why
Links that lead to
/startshould just navigate to/starter-packwhen clicking them within the app. Although the current behavior is generally fine, it is possible to trigger this crash with the current behavior:<RNSNavigationController: 0x111824200> is pushing the same view controller instance (<RNSScreen: 0x159982600>) more than once which is not supported and is most likely an error in the application : xyz.blueskyweb.app. It seems to only affect iOS users as well.How
Whenever we call
convertBskyAppUrlIfNeeded(), we can add a check to replace/start/with/starter-pack/if the link is indeed pointing toward/start/. While this is generally not needed after #4699 (which handles SP embeds natively instead of leaving them as external links), it would be good to ensure that even if someone pastes in a raw/start/link that it gets handled nicely.Test Plan
Weirdly, it took me a long time to actually repro the crash. It turns out you need to do the following to reproduce it (at least, this is how I was able to)
main)After this change, test the same. The crash no longer reproduces.