Log session events unconditionally #4758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4758.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cq6onj56l47c73bf96fg. |
|
haileyok
approved these changes
Jul 9, 2024
haileyok
pushed a commit
that referenced
this pull request
Jul 9, 2024
(cherry picked from commit 7a47656)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a log when an agent emits an event (
update,expired, and a few others). We want to get a baseline on how much expiration is occurring in practice, and we want to be able to target that with experiment fixes.Test Plan
Force early expiration using the short session debug header, verify it results in sending this event.